Skip to content

fix(@angular/ssr): ensure loadChildren runs in correct injection context during route extraction#30587

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:route-injector
Jun 25, 2025
Merged

fix(@angular/ssr): ensure loadChildren runs in correct injection context during route extraction#30587
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:route-injector

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Jun 24, 2025

Copy link
Copy Markdown
Collaborator

Ensure that loadChildren functions are executed within the route’s specific injection context when extracting routes, aligning behavior with Angular’s dependency injection model.

More context: angular/angular#62133

Closes #29483


Blocking until the next version of @angular/router is on NPM

@alan-agius4 alan-agius4 added state: blocked target: minor This PR is targeted for the next minor release labels Jun 24, 2025
@alan-agius4 alan-agius4 requested a review from dgp1130 June 24, 2025 11:35
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed area: @angular/ssr labels Jun 24, 2025
@alan-agius4 alan-agius4 removed the request for review from dgp1130 June 24, 2025 14:26
@alan-agius4 alan-agius4 removed action: review The PR is still awaiting reviews from at least one requested reviewer state: blocked labels Jun 24, 2025
…ntext during route extraction

Ensure that `loadChildren` functions are executed within the route’s specific injection context when extracting routes, aligning behavior with Angular’s dependency injection model.

More context: angular/angular#62133

Closes angular#29483
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 25, 2025
@alan-agius4 alan-agius4 merged commit f78b7bb into angular:main Jun 25, 2025
31 checks passed
@alan-agius4 alan-agius4 deleted the route-injector branch June 25, 2025 17:36
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Route-level Environment Initializer Skipped During AppEngine Route Discovery

2 participants